Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MSDK Maintenance Tool RISC-V/Visual Studio Code Support Co-Dependency #786

Closed
jlj-ee opened this issue Oct 27, 2023 · 4 comments
Closed
Assignees
Labels
enhancement New feature, request, or updating to latest version installer

Comments

@jlj-ee
Copy link
Contributor

jlj-ee commented Oct 27, 2023

Minor headache here:
At present, when I set up the MSDK installation, I exclude the RISC-V Embedded GCC component because I do not need it for my current projects/targets, and it requires a lot more disk space than the other components.
However, if I try to also install the Visual Studio Code Support component (which I do want/need), it seems to implicitly select the RISC-V component to download & install. Likewise, on a machine where I had installed RISC-V, uninstalling RISC-V apparently uninstalled VS Code support. Is this expected behavior?
I am on Windows.

Steps to reproduce:

  1. Run the maintenance tool on a system where the MSDK is already installed.
  2. De-select RISC-V and select Visual Studio Code support
    image
  3. Go to next, note that the installer displays the license agreement for RISC-V
    image
  4. Accept, note that the installer displays that it will be installing a component the same size as the RISC-V component (4.49GB as of the October 2023 MSDK release).
    image

I worked around this by just grabbing the VS Code support release from the VSCode-Maxim repo, but it seems like a bug in the Maintenance Tool/Installer.

@Jake-Carter
Copy link
Contributor

Hi @jlj-ee, the VS Code component has the RISC-V toolchain as a dependency because it relies on it to compile the RISC-V projects.

Unfortunately the QT installer framework enforces dependencies in both directions, so removing the RISC-V component will also remove any components that depend on it, including MAX78000/MAX78002 part support...

The behavior is expected, but in this case it's a pretty big limitation. Considering the disc space I think we can consider removing the direct dependencies for the toolchain components so users can uninstall them if needed, and just leave them as enabled by default.

@Jake-Carter
Copy link
Contributor

Speaking of the VSCode-Maxim repo - this reminded me I needed to tag the latest v1.6.2 release.

Just created a release page for it: https://github.com/Analog-Devices-MSDK/VSCode-Maxim/releases/tag/v1.6.2

@Jake-Carter Jake-Carter added installer enhancement New feature, request, or updating to latest version labels Oct 27, 2023
@Jake-Carter Jake-Carter self-assigned this Oct 27, 2023
@jlj-ee
Copy link
Contributor Author

jlj-ee commented Oct 27, 2023

VS Code component has the RISC-V toolchain as a dependency because it relies on it to compile the RISC-V projects

Yeah, I figured that was the case but I hoped that the installer would support excluding it since not all targets would require the RISC-V support.
As noted, this isn't a blocker, but I would say it caused some confusion because the co-dependency is not explicitly indicated by the installer. Thanks for considering it!

@Jake-Carter Jake-Carter added this to the Jan 2024 Release milestone Jan 5, 2024
Jake-Carter added a commit to analogdevicesinc/VSCode-Maxim that referenced this issue Feb 10, 2024
@Jake-Carter
Copy link
Contributor

Staged in v1.7.0 pre-release, target release date for the next MSDK update is Feb 16th

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature, request, or updating to latest version installer
Projects
None yet
Development

No branches or pull requests

2 participants