feat(PeriphDrivers): Add clock selection feature to WDT #808
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hfakkiz
added
MAX32655
Add clock selection feature of revB WDT to MAX32655, MAX32662, MAX32670, MAX32672, MAX32675, MAX32680, MAX32690, MAX78000 and MAX78002. Signed-off-by: Furkan Akkiz <[email protected]>
hfakkiz
force-pushed
the
feature/wdt-select-clock-source
branch
from
fd5c532 to
97b390e
Compare
Jake-Carter
suggested changes
Nov 28, 2023
Optimized code for some target numbers which has same clock sources for all instances. Signed-off-by: Furkan Akkiz <[email protected]>
Jake-Carter
suggested changes
Nov 29, 2023
There was a problem hiding this comment.
Thank you @hfakkiz, one last change request based on your latest comments
Jake-Carter
approved these changes
Dec 4, 2023
|
Thanks @hfakkiz, looks good to go. We'll get a second review then merge. |
ozersa
reviewed
Dec 5, 2023
ozersa
reviewed
Dec 5, 2023
Moved clock source check to RevB function and removed 'last_clock_source' parameter. Signed-off-by: Furkan Akkiz <[email protected]>
hfakkiz
force-pushed
the
feature/wdt-select-clock-source
branch
from
683953c to
a32227c
Compare
Jacob-Scheiffler
approved these changes
Dec 5, 2023
ozersa
approved these changes
Dec 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Description
WDT peripheral of MAX32655, MAX32662, MAX32670, MAX32672, MAX32675, MAX32680, MAX32690, MAX78000 and MAX78002 supports selecting different clock sources which are given in user guide.
Added a new function to set clksel register on revB WDT driver.
Added a new function to select supported clock sources for these part numbers.
Checklist Before Requesting Review