fix(CMSIS): Vector table address now properly set #819
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EricB-ADI
changed the title
Jake-Carter
approved these changes
Dec 6, 2023
There was a problem hiding this comment.
Nice
@Jacob-Scheiffler this would explain why the ISRs weren't working..........
|
@EricB-ADI I see on the AI87 we're doing Reset_Handler:
/* set start of flash in mvtec, with vectored mode */
la t0, (__FlashStart + 1)
csrrw x0, mtvec, t0I think we should also update this to use |
It wont make a difference because the ISR vector table is the first thing placed into the linker script of the text section. So they are the same. However, I think it is more explicit what is happening if you spell out isr vector inside the Reset_Handler |
AbbyWolf-ADI
approved these changes
Dec 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Inside the startup script for the RISCV MAX32655, the vector table was being set to 0, instead of the the ISR vector table so interrupts were not working correctly.