New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enum max_uart_flow_ctrl Naming Difference for MAX32670 #2473

Open

kilicomercan opened this issue Feb 27, 2025 · 1 comment

kilicomercan commented Feb 27, 2025

Uart flow control enumeration is defined as

enum max_uart_flow_ctrl {
UART_FLOW_DIS,
UART_FLOW_EN
};

for other MAX32XXX parts except MAX32670 in
no-OS/drivers/platform/maxim/max32670/maxim_uart.h file. This enum has been defined as,
enum max_uart_flow_ctrl {
MAX_UART_FLOW_DIS,
MAX_UART_FLOW_EN
};
for MAX32670.

So, developer needs to configure the application implementation according to the part number. It might be better to have a generic naming for this enum. If we apply this change, we should also update the example projects using uart for MAX32670.

Contributor

buha commented Mar 7, 2025 •

edited

Loading

thanks for reporting, i agree, they need to have the same name ! i would use the one with MAX_ prefix to reduce the chances of namespace conflicts, would you like to create a pull request ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment