Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logic Analyzer improvements #949

Closed
adisuciu opened this issue Nov 2, 2020 · 6 comments
Closed

Logic Analyzer improvements #949

adisuciu opened this issue Nov 2, 2020 · 6 comments

Comments

@adisuciu
Copy link
Contributor

adisuciu commented Nov 2, 2020

Logic analyzer:

  • channel names could be 1/2/3 instead of DIO0/DIO1/DIO2 - this would make them look cleaner on the plot. The handle should have the text centered.

  • Oneshot maximum buffersize: MAX_BUFFER_SIZE*64 instead of MAX_BUFFER_SIZE - use kernel buffers similar to streaming

  • Streaming - sample rate max 10msps but buffer can be any size

  • Oneshot mode should be selected by default

  • Trigger delay should be visible for both modes

  • There is an plotting artifact when plotting lare buffersizes

image

image

@DanielGuramulta
Copy link
Contributor

Created a separate issue to track the bug described in the above list: #972

@DanielGuramulta
Copy link
Contributor

Implemented with: #971

@tagoylo
Copy link

tagoylo commented Apr 7, 2021

On "channel names could be 1/2/3 instead of DIO0/DIO1/DIO2 - this would make them look cleaner on the plot. The handle should have the text centered."
Is it only the channel names on the handle or is it also applicable on the list of channels on the menu?

In logic analyzer, the name of the channel only changes the handle text and not the channel name list.
image

But in pattern generator, both changes.
image

@DanielGuramulta
Copy link
Contributor

On "channel names could be 1/2/3 instead of DIO0/DIO1/DIO2 - this would make them look cleaner on the plot. The handle should have the text centered."
Is it only the channel names on the handle or is it also applicable on the list of channels on the menu?

In logic analyzer, the name of the channel only changes the handle text and not the channel name list.
image

But in pattern generator, both changes.
image

Things should be more consistent now with pr: #1087

@tagoylo
Copy link

tagoylo commented Apr 28, 2021

Streaming - sample rate max 10msps but buffer can be any size

does the sample max rate correspond to this parameter? Should this be only 10 msps?
image

@adisuciu
Copy link
Contributor Author

Yes this is fine, if you up the nr of samples past a threshold you will get a warning.

@adisuciu adisuciu closed this as completed May 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants