Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the ability to use decimals (xx.yy) on Volume tag #55

Open
Roshri opened this issue Feb 11, 2024 · 4 comments
Open

Add the ability to use decimals (xx.yy) on Volume tag #55

Roshri opened this issue Feb 11, 2024 · 4 comments

Comments

@Roshri
Copy link

Roshri commented Feb 11, 2024

Where does this comes from?

Discussion started on MangaManager and Kavita support channels

MangaManagerORG/Manga-Manager#185

What is the rationale for adding support for this element?

I have some series (mainly manga) that release booklets or additional content bundled with limited editions of a given volume. These are commonly referenced as VolNumber.5 as they are intended to be read after said volume.

Adding decimals to the volume tag would allow reader and organizing software to display these between vol n and vol n+1

Is the element already handled by any application or tool?

Not that I'm aware of

@majora2007
Copy link

I think this would be an easy thing to accommodate. I saw discussion of it within Komga's discord as well. Kavita already has support out of the box if this is implemented.

@ajslater
Copy link
Contributor

ajslater commented Feb 12, 2024 via email

@majora2007
Copy link

I would be fine having it be a string and just staying on the spec it should be a number.

I can't think of a situation where a volume number could be something other than a number.

Making a string would align better with the rest of the spec.

@lordwelch
Copy link
Contributor

With CT it has never been possible to save a non-int value from the GUI. If the CLI was used it would have passed through whatever text was there until 2021 then it enforced it to be an int in all cases by stripping out non-number characters.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants