cmdserver is started and killed every operation during normal use

[ncalexan]

I've used monky for ages and just noticed that during "normal use" the cmdserver process will be started and killed every operation. At least, that's what I witness and what the use of unwind-protect around here suggests:

monky/monky.el

Lines 603 to 607 in e046322

	(unwind-protect
	(progn ,@body)
	(when (and monky-cmd-process outer (eq monky-process-type 'cmdserver))
	(delete-process monky-cmd-process)
	(setq monky-cmd-process nil)))))

The user can work around this with a manual (setq monky-cmd-process (monky-cmdserver-start)) but that's both awkward and not documented.

Perhaps this was supposed to be condition-case so that the delete-process only happens in error cases? Or perhaps there's supposed to be some other flow in normal use that I don't know about?

[Wilfred]

Yeah, I agree that looks broken. I've gradually been trying to reduce the amount of macros in monky, because I find the code hard to reason about.