Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Working with Google libs (grpc proto files) #11

Open
rajwilkhu opened this issue Aug 21, 2021 · 1 comment
Open

Working with Google libs (grpc proto files) #11

rajwilkhu opened this issue Aug 21, 2021 · 1 comment

Comments

@rajwilkhu
Copy link

Getting build errors (Error: ENOENT: no such file or directory, open /protos/app_engine_key.proto'. I have seen some discussions around this. Wondering if there is a workaround for this?

@Brian-McBride
Copy link
Contributor

I am talking with my contacts at Google about this.

It all comes down to the fact that they are importing the protobuffs using node's fs. Chasing it down, it looks like it was just a JSON file. It would be nice if they just did a regular import and enabled JSON file support in their settings.

Currently, this makes a LOT of Google libraries ones you have to put as exceptions as a list of items in the external array.

I would like to get a list of known packages that don't tree shake well in esbuild so that the repo could automatically add them to the external array with a user flag setting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants