add set layer limit #3464
add set layer limit #3464
Conversation
Signed-off-by: tomersein <[email protected]>
cmd/syft/internal/options/source.go
Outdated
| @@ -20,7 +22,8 @@ type sourceConfig struct { | |||
| } | |||
|
|
|||
| type fileSource struct { | |||
| Digests []string `json:"digests" yaml:"digests" mapstructure:"digests"` | |||
| Digests []string `json:"digests" yaml:"digests" mapstructure:"digests"` | |||
| MaxLayerSize string `json:"max-layer-size" yaml:"max-layer-size" mapstructure:"max-layer-size"` | |||
There was a problem hiding this comment.
Hey, @tomersein I think we should add this configuration to the imageSource (see here), instead of the fileSource. Other than that, I think this PR is probably good. Thanks 👍
There was a problem hiding this comment.
hi @kzantow the image-souce doesn't work when i put it inside, only filesource.
does it make sense?
There was a problem hiding this comment.
You need to add a PostLoad hook for the imageSource; I think it would look like this:
func (c *imageSource) PostLoad() error {
if c.MaxLayerSize != "" {
perFileReadLimit, err := humanize.ParseBytes(c.MaxLayerSize)
if err != nil {
return err
}
stereoscopeFile.SetPerFileReadLimit(int64(perFileReadLimit))
}
return nil
}
You could ensure it's the right signature with:
var _ clio.PostLoader = (*imageSource)(nil)
There was a problem hiding this comment.
@kzantow
fixed, however when I locally check it, for some reason I can reproduce the previous behavior.
I try to config 1B to the maximum layer size, just to make sure the set works.. but the scan passes.
I wonder if it related to some caching my laptop does.
Signed-off-by: tomersein <[email protected]>
Description
Please include a summary of the changes along with any relevant motivation and context,
or link to an issue where this is explained.
Type of change
Checklist: