Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

skip_if_exists not passed to centos parser within RHEL parser #17

Open
wagoodman opened this issue Dec 15, 2022 · 1 comment
Open

skip_if_exists not passed to centos parser within RHEL parser #17

wagoodman opened this issue Dec 15, 2022 · 1 comment
Labels
bug Something isn't working provider:rhel Relating to the RHEL provider question Further information is requested

Comments

@wagoodman
Copy link
Contributor

The RHEL parser uses the centos parser in order to download results. The centos parser has a skip_if_exists attribute that is leveraged by the centos provider based on the runtime config (wired into centos.Parser.get()). The same functionality in the RHEL parser is not wired to the internal centos parser instance even though there is a skip_if_exists feature for the RHEL provider as a whole.

Question: is leaving out skip_if_exists on the centos parser calls within the RHEL parser intentional? If so, we need some comments as to why to help folks out in the future.

@wagoodman wagoodman added bug Something isn't working question Further information is requested provider:rhel Relating to the RHEL provider labels Dec 15, 2022
@wagoodman
Copy link
Contributor Author

Note: I've updated the provider to pass the skip_if_exists option in #19, however, I'm leaving this issue open since it is still technically an unanswered question

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working provider:rhel Relating to the RHEL provider question Further information is requested
Projects
None yet
Development

No branches or pull requests

1 participant