Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error handling of deterministic minor errors #544

Open
willmurphyscode opened this issue Apr 18, 2024 · 0 comments
Open

Improve error handling of deterministic minor errors #544

willmurphyscode opened this issue Apr 18, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@willmurphyscode
Copy link
Contributor

Background:

Every now and then we see 403s from ALAS issues (e.g. as of this writing, https://alas.aws.amazon.com/AL2/ALAS-2024-2510.html returns 403).

Right now, this causes the entire operation of vunnel run -p amazon to exit non-zero, which might not be the behavior we want. Concretely, the first exception raised during the provider run halts the execution. HTTP GETs are retried 5 times, but this 403 is deterministic, so the retries don't help.

What would you like to be added:

We should be able to configure some continue-on-error semantics for vunnel; right now it's too all-or-nothing. For example, I should be able to write down, "provider X claims that there's a vulnerability we should download from example.com/some-cve, which is unreachable. Ignore this specific error." Or maybe "if you have fewer than 5 records that couldn't be retrieved, still consider the run successful."

This would allow us to better balance the competing priorities of "use yesterday's data instead of bad data," and "old data is bad."

Additional context:

Example failure: https://github.com/anchore/grype-db/actions/runs/8730962418/job/23970839142#step:6:1440

@willmurphyscode willmurphyscode added the enhancement New feature or request label Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: No status
Development

No branches or pull requests

1 participant