Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Insert new dvd ends in database problem because year is invalid after searching in imdb #164

Open
TEDDYXXL opened this issue Dec 13, 2022 · 4 comments
Labels
onhold Stuff that's not needed right now, or is awaiting other prerequisites...
Milestone

Comments

@TEDDYXXL
Copy link

Hi !

I find a possible bug during insert new dvd in my database after i search/find the title in imdb:

Database Problem
Out of range value for column 'year' at row 1
UPDATE videodata SET owner_id = 1, md5 = '', title = 'Death in Paradise', subtitle = '', language = '', diskid = '1041', mediatype = '1', comment = '', disklabel = '', imdbID = 'imdb:1888075', year = '1670935624125',
...

Regards,

Dirk

@johanneskonst
Copy link
Collaborator

Yes, year 1670935624125 will not happen for a long time.
If i add Death in Paradise to my copy (latest master) it correctly fetches 2011 as year.
Did you enter year yourself? And what version are you using? The one from release page here? Or the latest master from source?

@TEDDYXXL
Copy link
Author

I use the version from git (git clone ...) !
I didn't enter the year by hand. I search/take the entries from imdb.

@johanneskonst
Copy link
Collaborator

Thanks @TEDDYXXL but I cannot replicate this.
The only way I can get the year overflowing like this is if i enter big numbers by hand...
But i have stricter input validation on my wishlist, this will be fixed in due time.
Putting it on hold for now...
Thanks for helping out VideoDB!

@johanneskonst johanneskonst added the onhold Stuff that's not needed right now, or is awaiting other prerequisites... label Dec 15, 2022
@johanneskonst johanneskonst added this to the 4.2 milestone Dec 15, 2022
@TEDDYXXL
Copy link
Author

After latest update from today everything looks fine. Thanks. Good job.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
onhold Stuff that's not needed right now, or is awaiting other prerequisites...
Projects
None yet
Development

No branches or pull requests

2 participants