Interfaces don't enforce fields being implemented.

[phated]

I have a schema similar to:

let card: Schema.abstract_typ(unit, [ | `Pet]) =
  Schema.(
    interface(
      "Pet", ~doc="Interface which all pets must conform to", ~fields=_typ =>
      [
        abstract_field(
          "id",
          ~typ=non_null(string),
          ~args=Arg.[],
        ),
      ]
    )
  );

let dog =
  Schema.(
    obj("Dog", ~fields=_typ =>
      [
        field(
          "name",
          ~typ=non_null(string),
          ~args=Arg.[],
          ~resolve=(ctx, dog) => dog.name,
        ),
      ]
    )
  );

let cat =
  Schema.(
    obj("Cat", ~fields=_typ =>
      [
        field(
          "name",
          ~typ=non_null(string),
          ~args=Arg.[],
          ~resolve=(ctx, cat) => cat.name,
        ),
      ]
    )
  );

let dogAsPet = Schema.(add_type(pet, dog));
let catAsPet = Schema.(add_type(pet, cat));

But there are no errors produced unless I try to access the id field in a query. So this query actually succeeds:

query {
  pets {
    ... on Dog {
      name
    }
    ... on Cat {
      name
    }
  }
}

[andreas]

This is a known limitation, but unfortunately not documented 😞Whether an object correctly implements an interface is one of the things that cannot be captured in the type system. My current plan is to "just" implement it as an exception raising runtime check when calling Schema.add_type. Although inferior to a type error, I think it's a reasonable trade-off to have an exception at schema-construction time to be exception-free at query-execution time.

Here's the TODO in the source code:

ocaml-graphql-server/graphql/src/graphql_schema.ml

Line 510 in 9ec8c84

(* TODO add subtype check here *)

I'm happy to accept contributions, even if it's just a note in the README 😀