Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fields with differing arguments shouldn't be allowed #169

Open
dwwoelfel opened this issue Aug 28, 2019 · 0 comments
Open

Fields with differing arguments shouldn't be allowed #169

dwwoelfel opened this issue Aug 28, 2019 · 0 comments

Comments

@dwwoelfel
Copy link
Contributor

dwwoelfel commented Aug 28, 2019

Queries with differing arguments for the same field should not be allowed.

An example of a query that should fail (see swapi example)

query AllFilms {
  allFilms(first: 1) {
    totalCount
  }
  allFilms(first: 2) {
    pageInfo {
      hasNextPage
    }
  }
}

An example of a query that should succeed (see swapi example)

query AllFilms {
  allFilms(first: 1) {
    totalCount
  }
  allFilms(first: 1) {
    pageInfo {
      hasNextPage
    }
  }
}

If #168 gets merged, merge_selections would be a good place to do the check for conflicting arguments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant