Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Right Preconditioning bug #81

Open
freiler opened this issue Oct 12, 2020 · 0 comments
Open

Right Preconditioning bug #81

freiler opened this issue Oct 12, 2020 · 0 comments

Comments

@freiler
Copy link

freiler commented Oct 12, 2020

Using Gmres, the right preconditioning is not working properly. The error might be on line 948 of 'linsys.py'.

return self.x0 + self.linear_system.Mr * yk

Multiplying yk by the right preconditioner does not seem right. Instead, it should be an extra linear solve of the form

self.linear_system.Mr^(-1) * yk

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant