timedelete.php fails because of a bad regex on line 289

[abarclay]

As a workaround, I changed the regex seperators to % symbols like this:
elseif (preg_match('%' . "^([0-9]{1,2})-,/,.-,/,.$" . '%i', $post_date, $date_regs))

Now the error I am getting is about $tso not being set. As a workaround I set $tso = 0 at the top of the file. Now the delete function works.

[boelle]

mine looked a bit different

} elseif (preg_match('%' . "^([0-9]{1,2})-,/,.-,/,.$" . '%i', $post_date, $date_regs)) {

but there is no $tso no where in the file

[boelle]

but no need to change $tso

changing the seperators was enough

[tvandame]

Is someone going to open a pull request for this change.

[boelle]

the problem is that the whole system needs an overhaul to be up to date in regards of most modern php and sql versions... if you look arround at the other issues you will also see that the git owner is not much arround

[tvandame]

Yea I was thinking about it on my way home form work... I thought maybe I should fork it and start patching out standing issues. Then once it's more stable start a re-write in a modern framework. I would only be doing this to keep my development skills up seeing I'm now in management.

[boelle]

my skills are limited to copy&paste and hack code from instructions given. and to test functions as such. the description of the system says it can compute overtime, but i raised an seperate issue on that since there are no where to enter normal work hours. otherwise the system's general thought and idea is not bad

[davidwachs]

The code on the "timeedit.php" page works, so if you copy this preg_match:
} elseif (preg_match('/' . "^([0-9]{1,2})[-\,\/,.]([0-9]{1,2})[-\,\/,.](([0-9]{2})|([0-9]{4}))$" . '/i', $post_date, $date_regs)) {
it seems to work fine..

[boelle]

i gave up on the software in general... that is also why i have not posted in more than a year

[davidwachs]

its a shame, because i think it's very usable software. Have you found any good, free alternatives?

[ddziubanski]

We managed to get it working quite well, we're not using it as a "timeclock" system, but we utilize it as a electronic sign in sheet for secured data center rooms, as we have to keep logs that match with door badge, works well.

…

On Thu, Nov 2, 2017 at 9:11 AM, David ***@***.***> wrote: its a shame, because i think it's very usable software. Have you found any good, free alternatives? — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#24 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AOwSwLKpdfhKchWkbjia_JuApTPfAJ6Eks5syemUgaJpZM4HGiIP> .