Remove noinlinephpdocs check (moodlehq#144)

Replaced with moodlehq/moodle-cs#137

Author: andrewnicols

file.php

@@ -1201,15 +1201,6 @@ public function is_broken_description() {
         return $this->brokentext;
     }
 
-    /**
-     * Returns true if this is an inline phpdoc comment (starting with three slashes)
-     *
-     * @return bool
-     */
-    public function is_inline() {
-        return preg_match('|^\s*///|', $this->originaltoken[1]);
-    }
-
     /**
      * Returns the original token storing this phpdocs
      *

lang/en/local_moodlecheck.php

@@ -37,9 +37,6 @@
 
 $string['error_emptynophpfile'] = 'The file is empty or doesn\'t contain PHP code. Skipped.';
 
-$string['rule_noinlinephpdocs'] = 'There are no comments starting with three or more slashes';
-$string['error_noinlinephpdocs'] = 'Found comment starting with three or more slashes';
-
 $string['error_phpdocsinvalidinlinetag'] = 'Invalid inline phpdocs tag <b>{$a->tag}</b> found';
 $string['rule_phpdocsinvalidinlinetag'] = 'Inline phpdocs tags are valid';
 

rules/phpdocs_basic.php

@@ -24,28 +24,11 @@
 
 defined('MOODLE_INTERNAL') || die;
 
-local_moodlecheck_registry::add_rule('noinlinephpdocs')->set_callback('local_moodlecheck_noinlinephpdocs');
 local_moodlecheck_registry::add_rule('functionarguments')->set_callback('local_moodlecheck_functionarguments');
 local_moodlecheck_registry::add_rule('phpdocsinvalidinlinetag')->set_callback('local_moodlecheck_phpdocsinvalidinlinetag');
 local_moodlecheck_registry::add_rule('phpdocsuncurlyinlinetag')->set_callback('local_moodlecheck_phpdocsuncurlyinlinetag');
 local_moodlecheck_registry::add_rule('phpdoccontentsinlinetag')->set_callback('local_moodlecheck_phpdoccontentsinlinetag');
 
-/**
- * Checks that no comment starts with three or more slashes
- *
- * @param local_moodlecheck_file $file
- * @return array of found errors
- */
-function local_moodlecheck_noinlinephpdocs(local_moodlecheck_file $file) {
-    $errors = [];
-    foreach ($file->get_all_phpdocs() as $phpdocs) {
-        if ($phpdocs->is_inline()) {
-            $errors[] = ['line' => $phpdocs->get_line_number($file)];
-        }
-    }
-    return $errors;
-}
-
 /**
  * Check that all the inline phpdoc tags found are valid
  *