Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests failing on cln v24.05 #2

Open
daywalker90 opened this issue Jun 5, 2024 · 4 comments
Open

Tests failing on cln v24.05 #2

daywalker90 opened this issue Jun 5, 2024 · 4 comments

Comments

@daywalker90
Copy link

Hi the tests are failing with cln v24.05. Plugins who don't have tests or failing tests will be moved to the archived section of the plugins repo soon.

See CI run https://github.com/lightningd/plugins/actions/runs/9392061346
@Impa10r
Copy link
Contributor

Impa10r commented Sep 1, 2024 •
edited
Loading

@daywalker90 This PR fixes it.

@andrewtoth
Copy link
Owner

Sorry, I don't have time to actively maintain this. If #3 fixes it I can merge that.

@andrewtoth
Copy link
Owner

Merged #3. Can we re-run the CI @daywalker90 ?

@daywalker90
Copy link
Author

I've opened a PR for an update on the plugins repo: lightningd/plugins#587

The CI failed because of the DEVELOPER import. Just remove that everywhere, it's no longer needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@andrewtoth @daywalker90 @Impa10r