ack code review comments for predictive back cross activity sample

ashnohe · ashnohe · commit fcdd8e65bf23 · 2023-09-25T09:24:56.000-07:00
diff --git a/samples/user-interface/predictiveback/README.md b/samples/user-interface/predictiveback/README.md
@@ -13,13 +13,13 @@ stop using animation and to instead use animator and androidx transitions for mo
     override fun onCreate(savedInstanceState: Bundle?) {
         "..."
 
-        this.overrideActivityTransition(
+        overrideActivityTransition(
             OVERRIDE_TRANSITION_OPEN,
             android.R.anim.fade_in,
             0
         )
     
-        this.overrideActivityTransition(
+        overrideActivityTransition(
             OVERRIDE_TRANSITION_CLOSE,
             0,
             android.R.anim.fade_out
diff --git a/samples/user-interface/predictiveback/src/main/java/com/example/platform/ui/predictiveback/PBCustomCrossActivityAnimation.kt b/samples/user-interface/predictiveback/src/main/java/com/example/platform/ui/predictiveback/PBCustomCrossActivityAnimation.kt
@@ -32,14 +32,14 @@ class PBCustomCrossActivityAnimation : AppCompatActivity() {
         binding = ActivityCustomCrossAnimationBinding.inflate(layoutInflater)
         setContentView(binding.root)
 
-        this.overrideActivityTransition(
+        overrideActivityTransition(
             OVERRIDE_TRANSITION_OPEN,
             android.R.anim.fade_in,
             0
         )
 
 
-        this.overrideActivityTransition(
+        overrideActivityTransition(
             OVERRIDE_TRANSITION_CLOSE,
             0,
             android.R.anim.fade_out

Original file line number	Diff line number	Diff line change
`@@ -13,13 +13,13 @@ stop using animation and to instead use animator and androidx transitions for mo`
`13`	`13`	`override fun onCreate(savedInstanceState: Bundle?) {`
`14`	`14`	`"..."`
`15`	`15`
`16`		`- this.overrideActivityTransition(`
	`16`	`+ overrideActivityTransition(`
`17`	`17`	`OVERRIDE_TRANSITION_OPEN,`
`18`	`18`	`android.R.anim.fade_in,`
`19`	`19`	`0`
`20`	`20`	`)`
`21`	`21`
`22`		`- this.overrideActivityTransition(`
	`22`	`+ overrideActivityTransition(`
`23`	`23`	`OVERRIDE_TRANSITION_CLOSE,`
`24`	`24`	`0,`
`25`	`25`	`android.R.anim.fade_out`
Original file line number	Diff line number	Diff line change
`@@ -32,14 +32,14 @@ class PBCustomCrossActivityAnimation : AppCompatActivity() {`
`32`	`32`	`binding = ActivityCustomCrossAnimationBinding.inflate(layoutInflater)`
`33`	`33`	`setContentView(binding.root)`
`34`	`34`
`35`		`- this.overrideActivityTransition(`
	`35`	`+ overrideActivityTransition(`
`36`	`36`	`OVERRIDE_TRANSITION_OPEN,`
`37`	`37`	`android.R.anim.fade_in,`
`38`	`38`	`0`
`39`	`39`	`)`
`40`	`40`
`41`	`41`
`42`		`- this.overrideActivityTransition(`
	`42`	`+ overrideActivityTransition(`
`43`	`43`	`OVERRIDE_TRANSITION_CLOSE,`
`44`	`44`	`0,`
`45`	`45`	`android.R.anim.fade_out`