utils: fix container-overflow in tracking allocator

=================================================================
==524==ERROR: AddressSanitizer: container-overflow on address 0x52100028a100 at pc 0x7f29c0bf51fd bp 0x7ffda75397d0 sp 0x7ffda75397c8
READ of size 4 at 0x52100028a100 thread T0
    #0 0x7f29c0bf51fc in util::mem_tracker::pretty_print_ascii() const /var/lib/buildkite-agent/builds/buildkite-amd64-builders-i-024f8676eb7b139e9-1/redpanda/vtools/src/v/utils/tracking_allocator.cc:75:31
    #1 0x55be1ac7eb7b in mem_tracker_pretty_printing::test_method() /var/lib/buildkite-agent/builds/buildkite-amd64-builders-i-024f8676eb7b139e9-1/redpanda/vtools/src/v/utils/tests/tracking_allocator_tests.cc:82:5
    #2 0x55be1ac7d651 in mem_tracker_pretty_printing_invoker() /var/lib/buildkite-agent/builds/buildkite-amd64-builders-i-024f8676eb7b139e9-1/redpanda/vtools/src/v/utils/tests/tracking_allocator_tests.cc:50:1

Signed-off-by: Noah Watkins <[email protected]>

Author: dotnwat

src/v/utils/tracking_allocator.cc

@@ -71,8 +71,8 @@ ss::sstring mem_tracker::pretty_print_ascii() const {
         // rooted at the current tracker to avoid an O(n^2) loop.
         result << pretty_print_ascii_level(
           top.first, tracker._label, tracker._consumption);
-        stack.pop();
         auto next_level = top.first + 1;
+        stack.pop();
         for (const auto& child : tracker._children) {
             stack.push(std::pair(next_level, std::cref(child)));
         }