Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dynamic-federation.ts - loadRemoteEntries uses Promise.all() but should use Promise.allSettled() #374

Open
tomsontom opened this issue Nov 10, 2023 · 0 comments · May be fixed by #375
Open

dynamic-federation.ts - loadRemoteEntries uses Promise.all() but should use Promise.allSettled() #374

tomsontom opened this issue Nov 10, 2023 · 0 comments · May be fixed by #375

Comments

@tomsontom
Copy link

We ran in a bug today because one of our remotes was not available and then invalid singleton versions have been loaded upon application bootstraping.

We tracked the problem down to the fact the when loading the remotes the code uses a Promise.all() who according to the documentation resolves at the moment one of the sub-promises rejects. We think the correct solution is to use Promise.settled() so that it ensure that ALL remotes have been loaded successfully/not sucessfully.

module-federation-plugin/libs/mf-runtime/src/lib/loader/dynamic-federation.ts

Line 325 in d0bc565

await Promise.all(promises);

@tomsontom tomsontom linked a pull request Nov 10, 2023 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

wait for all promises to resolve/reject tomsontom/module-federation-plugin
1 participant
@tomsontom