Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Native Federation] outputPath from "architect/build/options" it's being ignored #690

Open
1 of 2 tasks
aramirezj opened this issue Nov 9, 2024 · 0 comments · May be fixed by #691
Open
1 of 2 tasks

[Native Federation] outputPath from "architect/build/options" it's being ignored #690

aramirezj opened this issue Nov 9, 2024 · 0 comments · May be fixed by #691

Comments

@aramirezj
Copy link

aramirezj commented Nov 9, 2024

With what library do you have an issue?

native-federation

Reproduction of the bug/regression with instructions

If the "outputPath" is added to the angular.json, and then the project is compiled with ng build, it will not listen the property

Having the property with:

"outputPath":"/relative/path/"

After ng build is executed:

Instead of having the distribution folder like this:

"dist/projectX/relative/path/browser"

It ends up like:

"dist/projectX/browser"

This property is normally used along with the "baseHref" that has been fixed recently.

The issue can be reproduced here and running the ng build --project host.

Expected behavior

That after running ng build --project host the distribution folder looks like "dist/projectX/browser"

Versions of Native/Module Federation, Angular, Node, Browser, and operating system

"@angular-architects/native-federation": "^18.2.1",
"@angular/core": "^18.2.4"

Node 22.9.0
Browser: Chrome
OS: Windows

Other information

Also the param --output-path when running ng build --project host --output-path custom gives unknown property

I would be willing to submit a PR to fix this issue

  • Yes
  • No
@aramirezj aramirezj changed the title outputPath from "architect/build/options" it's being ignored [Native Federation] outputPath from "architect/build/options" it's being ignored Nov 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant