Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: drap and drop a angular app folder will set the Klingon UI accordingly (restore mode) #50

Open
sumitparakh opened this issue Sep 8, 2018 · 4 comments
Open

feat: drap and drop a angular app folder will set the Klingon UI accordingly (restore mode) #50

sumitparakh opened this issue Sep 8, 2018 · 4 comments
Assignees
@sumitparakh
Labels
backlog effort2: medium (days) package: @klingon/ui type: feature

Comments

@sumitparakh
Copy link
Member

Klingon should be able to restore based on dropped angular app project/folder.
@sumitparakh
Copy link
Member Author

I am thinking of overlaying whole app screen, instead of just tab group element when dropping starts. Would that be ok?

@sumitparakh sumitparakh mentioned this issue Sep 8, 2018
Open
30 tasks
@manekinekko
Copy link
Member

manekinekko commented Sep 9, 2018 •
edited
Loading

Hey @sumitparakh thank you for starting this.

What you suggest is fine. Let's iterate over your PR.

@sumitparakh
Copy link
Member Author

It's almost ready. I shall give PR after some local testing and updating few changes as per #56 .

sumitparakh added a commit to sumitparakh/klingon that referenced this issue Oct 13, 2018
@sumitparakh
fix(feature): drag and drop angular project
230fe38 
drap and drop angular project will set the klingon ui accordingly

restore mode, issue angular-klingon#50
@sumitparakh sumitparakh mentioned this issue Oct 13, 2018
Merged
sumitparakh added a commit to sumitparakh/klingon that referenced this issue Oct 15, 2018
@sumitparakh
feat(feature): drag and drop angular project
5e49aa2 
drap and drop angular project will set the klingon ui accordingly

restore mode, issue angular-klingon#50
@sumitparakh
Copy link
Member Author

I missed electron app part in my latest PR. I shall update it in the same PR #62

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sumitparakh sumitparakh

Labels
backlog effort2: medium (days) package: @klingon/ui type: feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@manekinekko @sumitparakh