No possibility of using invalid values with Datepicker #6054

Activity

1. wesleycho commented on Jun 27, 2016

   

   wesleycho

   on Jun 27, 2016

   Contributor

   More actions

   The allowInvalid setting is for changes started from a view, not from a model (see how Angular uses allowInvalid here: https://github.com/angular/angular.js/blob/master/src/ng/directive/ngModel.js). You would need to attach a custom directive and execute ngModel.$setViewValue(customValue).

   As for adding baked in support from model changes, I'm leaning towards rejecting this request - IMO this is a perversion of what that option was created for in Angular. In addition, this likely would have unintended consequences with the datepicker and popup that could potentially break the datepicker.

   I would be willing to potentially support a PR that adds support for this using a different option unique to the popup, but it also needs to be well-tested along with a reproduction in Plunker demonstrating it works properly.
2. wesleycho

   added

   type: enhancement

   component: datepicker

   PRs plz!

   component: datepicker-popup

   on Jun 27, 2016
3. npbenjohnson commented on Apr 14, 2017

   

   npbenjohnson

   on Apr 14, 2017

   Last edited by npbenjohnson

   More actions

   1. User enters custom date string, saves form
   2. User reloads form, date string is hidden, although still in model (which means it can't be reviewed or corrected)

   Seems like a very common use case that is completely broken right now, and allowInvalid on any standard form control would behave in a way that doesn't break it. Special-casing the setting, unless there is an unmanageable technical issue, seems like a strange choice.

   👍React with 👍1Reacted by Nathan Hillyer
4. npbenjohnson

   added a commit that references this issue on Apr 14, 2017

   fix(datepickerPopup): support ngModelOptions.allowInvalid angular-ui#…

   ...

   a710c87