Form gets $dirty by default with debounce = false #315

Activity

1. deeg

   added

   needs plunker

   on Jan 16, 2017
2. deeg commented on Jan 16, 2017

   

   deeg

   on Jan 16, 2017

   Contributor

   More actions

   Please post a plunker reproducing the issue so people can look into fixing it.

   A PR fixing the issue would be nice if you have found a reproducible bug.
3. iJungleboy commented on Jan 17, 2017

   

   iJungleboy

   on Jan 17, 2017

   Author

   More actions

   sorry for seeming daft, but I've never made a plunkr. Do you have a good sample using angular-ui-tinymce unto which I could then build upon?
4. christophbuehler commented on Apr 4, 2017

   

   christophbuehler

   on Apr 4, 2017

   Last edited by christophbuehler

   More actions

   @deeg If debounce is set to 'false', no dirty-check is made before updating the view. Therefore, the editor is considered dirty by default if any of the events ('ExecCommand change NodeChange ObjectResized') are triggered. Take a look at 'debouncedUpdate', which performs a dirty-check.
   https://github.com/angular-ui/ui-tinymce/blob/master/src/tinymce.js#L95-L102

   A tested patch:

   // Update model when:
   // - a button has been clicked [ExecCommand]
   // - the editor content has been modified [change]
   // - the node has changed [NodeChange]
   // - an object has been resized (table, image) [ObjectResized]
   ed.on('ExecCommand change NodeChange ObjectResized', function () {
       if (options.debounce) debouncedUpdate(ed);
       else if (ed.isDirty()) {
           ed.save();
           updateView(ed);
       }
   });