Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider adding a wrapper around jasmine_node_test rule #338

Open
AndrewKushnir opened this issue Jan 4, 2022 · 0 comments
Open

Consider adding a wrapper around jasmine_node_test rule #338

AndrewKushnir opened this issue Jan 4, 2022 · 0 comments

Comments

@AndrewKushnir
Copy link
Contributor

PR angular/angular#44505 updated angular/angular repo to use ES2015 instead of ES5. The mentioned change revealed that there is a duplication in a lot of places where the bootstrap is defined, for example:

jasmine_node_test(
    bootstrap = ["//tools/testing:node_no_angular_es2015"],

or:

jasmine_node_test(
    bootstrap = ["//tools/testing:node_es2015"],

This makes further ES version upgrades quite error-prone (and time-consuming), since we need to change ~100 files.

The proposal is to create a couple wrappers, for example:

  • ng_node_test
  • no_ng_node_test

and specify bootstrap there by default (and allow overrides), so that it's easier to update ES version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant