Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tooling to accept payload size changes #443

Open
AndrewKushnir opened this issue Mar 1, 2022 · 0 comments
Open

Tooling to accept payload size changes #443

AndrewKushnir opened this issue Mar 1, 2022 · 0 comments
Labels

Comments

@AndrewKushnir
Copy link
Contributor

Currently in the angular/angular repo, when a change affects payload size for integration test app or AIO, an error is thrown on CI (example CI failure):

FAIL: Commit undefined uncompressed main fell below expected size by 500 bytes or >1% (expected: 231381, actual: 230780).
If this is a desired change, please update the size limits in file '../.cache/bazel/_bazel_circleci/9ce5c2144ecf75d11717c0aa41e45a8d/execroot/angular/bazel-out/k8-fastbuild/bin/integration/cli-hello-world-lazy/test.sh.runfiles/angular/goldens/size-tracking/integration-payloads.json'.

We have a number of test apps (~10) for which we track payload size, thus it takes time to manually update everything. Also, minor payload size deltas between the main and a patch branches causes issues during the merge (when merge is requested to both main and patch branches), thus engineers end up creating a new PR and re-do all the manual updates to payload sizes once again.

It'd be great if we can have a tooling to update payload sizes, similar to what we have for tracking the symbols (via yarn symbol-extractor:update). That'd improve the quality of life for us, reduce CI reruns and save a bunch of time.

Also, I noticed that the payload size error for each app is present in the CI output more than once. Do we run it multiple times for some reasons?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant