Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Convert BitRate and Information to double (#1353)
In PR #1195 @angularsen asks @tmilnthorp: > Question; what do you think of also changing Information/BitRate from decimal to double? > > On one hand, it is sort of weird to risk getting rounding errors like 8.00000001 bits. On the other hand, for all other units (kilobyte, etc) that are probably way more used, floating point is perhaps the expected value representation. > > If we change all 3 quantities to double, we have the potential to clean up a LOT of QuantityValue complexity. How about we continue that discussion here? 😄 This PR is pretty straightforward and mimics #1195, except that `Information` is used as the typical decimal quantity in some tests. Because there won't be any decimal quantities left if these PRs get merged, I removed those tests in anticipation of completely removing all decimal support. --------- Co-authored-by: Andreas Gullberg Larsen <[email protected]>
- Loading branch information