Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix more unit names #1351

Merged
merged 3 commits into from
Jan 6, 2024
Merged

Conversation

Muximize
Copy link
Contributor

@Muximize Muximize commented Jan 5, 2024

Came across some more unit names that seem wrong. Breaking changes once more.

Related #1200

@@ -30,7 +30,7 @@
},
{
"SingularName": "MeterPerMinute",
"PluralName": "MetersPerMinutes",
"PluralName": "MetersPerMinute",
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Jeez, we had this many errors in plural form? I must have been sloppy in the reviews 😓

Nice to get them corrected though!

@angularsen angularsen merged commit ab2618e into angularsen:release/v6 Jan 6, 2024
1 check passed
@angularsen angularsen mentioned this pull request Jan 6, 2024
14 tasks
@Muximize Muximize deleted the fix-unit-names branch January 6, 2024 18:38
@Muximize
Copy link
Contributor Author

Muximize commented Jan 7, 2024

This fixes #1330

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants