Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate from Travis CI to GitHub Action #1273

Closed
wants to merge 1 commit into from
Closed

Migrate from Travis CI to GitHub Action #1273

wants to merge 1 commit into from

Conversation

Dinesh101041
Copy link

Migrate from Travis CI to GitHub Action

  1. node.yaml - Action for javascript
  2. css.yaml - Action for css
  3. lint.yaml - Action for lints

Deleted Travis.yml workflow

Fix #1221

@eltonmesquita
Copy link
Collaborator

Thanks for the PR @Dinesh101041. I've been in a short time schedule lately, but I should be able to review your lovey PR in the next few days. Sorry for taking so much time.

Copy link
Collaborator

@eltonmesquita eltonmesquita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm so sorry for taking so long to review, but I'm back in business and should give feedback faster from now on.

Thanks for the PR. There are a few questions as you can see.

@@ -0,0 +1,36 @@
# This is a basic workflow to help you get started with Actions

name: CI
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This job won't do anything. What's the meaning of having it? 🤔

# Run Linter against code base #
################################
- name: Lint Code Base
uses: github/super-linter@v3
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't know this linter but I had a quick look and we might be better with a simple eslinter setup. I can add eslinter and prettier so you can update this to a simple npm package script. What do you think?

Comment on lines +26 to +27
- run: npm run docs
- run: npm run build --if-present
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will this add the compiled files to the current PR? Else, what's the end result?

Copy link
Author

@Dinesh101041 Dinesh101041 Jun 30, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry for late reply i am not well in github actions i done this on reading github node workflow doc
here is link of two docs Github node workflow
i will delete the linter and css workflow we can add the eslinter setup

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any updates on this?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any updates on this?

can you please elaborate the conflict and i will delete this pull and make a new pull with all update

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any updates on this?

can you please elaborate the conflict and i will delete this pull and make a new pull with all update

@eltonmesquita can you please elaborate on it?

@warengonzaga
Copy link
Member

I think this PR has some conflicts... can you update this @Dinesh101041?

@warengonzaga
Copy link
Member

Hi @Dinesh101041 any update on this? cc: @eltonmesquita just checking things here.

@Dinesh101041
Copy link
Author

Hi @Dinesh101041 any update on this? cc: @eltonmesquita just checking things here.

not able to work after that due to other works

@eltonmesquita
Copy link
Collaborator

I'll close this one as it's outdated by now. I'll take some time and do it myself as it's a task that involves a few other ones.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move from Travis CI to Github Actions
3 participants