-
Notifications
You must be signed in to change notification settings - Fork 12
-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
App Lifecycle Improvement #2
Comments
Thanks for the head-up. Would you like to create a PR ? I would gladly review and merge it. |
Sure. I'll try to get to this over the weekend. Best, Mike
…On Wed, Apr 22, 2020 at 9:57 AM Anis ***@***.***> wrote:
Thanks for the head-up. Would like to create a PR ? It would gladly review
and merge it.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#2 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AE5JNM7YJS2AIPVYH2ACAV3RN4OWVANCNFSM4MLM4SMA>
.
|
it was fixed? |
@prsolucoes surely not, I'm still waiting for the PR |
Does this problem persist? |
yes, it's still in need of a brave one to fix it. I'm not event working in android projects, so I'm event less incline to fix it now than last year, sadly 😭 |
I’ll try to do this next week. I pointed out the issue and have fixed it
locally.
…On Tue, Aug 10, 2021 at 10:07 AM Anis ***@***.***> wrote:
Does this problem persist?
yes, it's still in need of a brave one to fix it. I'm not event working in
android projects, so I'm event less incline to fix it now than last year,
sadly 😭
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#2 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AE5JNM2JBYYKYPIFIN6B7VTT4FMG3ANCNFSM4MLM4SMA>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email>
.
|
Hi @woodmicha, Can you open a pull-request? Thanks. |
Thank you for creating and publishing your solution here. I've identified one improvement adding the interface
LifecycleObserver
to the App and to invokeregisterConnectivityMonitor()
in theLifecylcle.Event.ON_RESUME
callback. I had to addimplementation 'androidx.lifecycle:lifecycle-process:2.2.0'
tobuild.gradle
to support thisThe basis for this was the app was losing the ability to monitor the events after it was Paused.
Thanks again for the crafty kotlin. I found it super educational on many different aspects of the language while solving a frustrating source for many errors within our app.
The text was updated successfully, but these errors were encountered: