Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App Lifecycle Improvement #2

Open
woodmicha opened this issue Apr 18, 2020 · 8 comments
Open

App Lifecycle Improvement #2

woodmicha opened this issue Apr 18, 2020 · 8 comments
Assignees
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@woodmicha
Copy link

Thank you for creating and publishing your solution here. I've identified one improvement adding the interface LifecycleObserver to the App and to invoke registerConnectivityMonitor() in the Lifecylcle.Event.ON_RESUME callback. I had to add implementation 'androidx.lifecycle:lifecycle-process:2.2.0' to build.gradle to support this

The basis for this was the app was losing the ability to monitor the events after it was Paused.

Thanks again for the crafty kotlin. I found it super educational on many different aspects of the language while solving a frustrating source for many errors within our app.

@anis-campos anis-campos self-assigned this Apr 22, 2020
@anis-campos
Copy link
Owner

anis-campos commented Apr 22, 2020

Thanks for the head-up. Would you like to create a PR ? I would gladly review and merge it.

@woodmicha
Copy link
Author

woodmicha commented Apr 23, 2020 via email

@anis-campos anis-campos added bug Something isn't working enhancement New feature or request and removed bug Something isn't working labels May 19, 2020
@paulocoutinhox
Copy link

it was fixed?

@anis-campos
Copy link
Owner

@prsolucoes surely not, I'm still waiting for the PR

@sergiofdomingues
Copy link

Does this problem persist?

@anis-campos anis-campos added the help wanted Extra attention is needed label Aug 10, 2021
@anis-campos
Copy link
Owner

Does this problem persist?

yes, it's still in need of a brave one to fix it. I'm not event working in android projects, so I'm event less incline to fix it now than last year, sadly 😭

@woodmicha
Copy link
Author

woodmicha commented Aug 10, 2021 via email

@paulocoutinhox
Copy link

Hi @woodmicha,

Can you open a pull-request?

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

4 participants