Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CODING:develop the contribution section in the project page. #80

Open
4 tasks done
nandini45 opened this issue Jun 18, 2020 · 52 comments · May be fixed by #173
Open
4 tasks done

CODING:develop the contribution section in the project page. #80

nandini45 opened this issue Jun 18, 2020 · 52 comments · May be fixed by #173
Assignees
@Bucky25
Labels
Category: Coding Changes to code base or refactored code that doesn't fix a bug. Status: Available Issue was approved and available to claim or abandoned for over 3 days.

Comments

@nandini45
Copy link
Member

nandini45 commented Jun 18, 2020 •
edited by husainattar
Loading

Description

As a developer,
I need the following section of mockup to be developed,
so that I can add it in my projects page.
https://xd.adobe.com/view/e83904d0-fe4d-47c1-7762-155628f7de25-9e08/

Mocks

image

sizing/spacing-
image

(i didn't add the last 30 days of contri but it has to be added in the section and the spacing between last 30 days and the first heading is 32)
[
Font Style- Avenir Weight-medium
color style-#0071BC
]

Acceptance Criteria

Update [Required]

  • Follows all the design guidelines as mentioned and is responsive enough on large screen devices.
  • Fetch the details of the project that is (the contribution)made in the project(LAST 30 DAYS)

Definition of Done

  • Approval by 2 mentor.
  • All of the required items are completed.

Estimation
5-6 hours
@nandini45 nandini45 added Category: Coding Changes to code base or refactored code that doesn't fix a bug. Status: Available Issue was approved and available to claim or abandoned for over 3 days. labels Jun 18, 2020
@nandini45
Copy link
Member Author

@annabauza can you review the issue?

@annabauza
Copy link
Contributor

Actually last 30 days is the same font color

@nandini45
Copy link
Member Author

@anitab-org/coding-team can someone work on this issue?

@anna4j
Copy link
Contributor

anna4j commented Jun 28, 2020

@nandini45 I'd like to work on this!

@adi-001
Copy link
Contributor

adi-001 commented Jun 28, 2020

@anna4j , go ahead - assigned it to you🙃

@anna4j
Copy link
Contributor

anna4j commented Jun 30, 2020

I'm facing some issues with the react-native-svg package that is needed for the contribution graph. It shows syntax error of Unexpected token
in one of the module files itself :(
The react-native-svg-web package shows the same error
how can I go about this? thanks

@nandini45 nandini45 removed the Status: Available Issue was approved and available to claim or abandoned for over 3 days. label Jun 30, 2020
@nandini45
Copy link
Member Author

nandini45 commented Jun 30, 2020 •
edited
Loading

@anna4j can u share the screenshot please?
as far as i know unexpected token arises mostly because of some fault in syntax, maybe you have added some extra keyword anything?

@anna4j
Copy link
Contributor

anna4j commented Jul 1, 2020

@nandini45
image

So this is the error I've been stuck on. "Line" is a component imported from the react-native-svg package and it's contained in a .tsx file

@anna4j
Copy link
Contributor

anna4j commented Jul 3, 2020

I'm working on this issue, sorry for the delay. I aim to open a pull request soon!

@anna4j anna4j removed their assignment Jul 6, 2020
@anna4j
Copy link
Contributor

anna4j commented Jul 6, 2020

could someone else please take up this issue? I'm facing issues with the react-native modules that haven't been developed for the web yet but are being used in this thanks.

@nandini45 nandini45 added the Status: Available Issue was approved and available to claim or abandoned for over 3 days. label Jul 8, 2020
@PriViji
Copy link

PriViji commented Jul 15, 2020

Hi, Is this available?

@gaurivn
Copy link
Member

gaurivn commented Jul 15, 2020

Yes it is.

@PriViji
Copy link

PriViji commented Jul 15, 2020

I would like to take up

@gaurivn gaurivn removed the Status: Available Issue was approved and available to claim or abandoned for over 3 days. label Jul 15, 2020
@nandini45
Copy link
Member Author

@PriViji can you update us whether you are working on issue or not?

@PriViji
Copy link

PriViji commented Jul 21, 2020 via email

@nandini45
Copy link
Member Author

nandini45 commented Jul 21, 2020 •
edited
Loading

@PriViji no issue. take your time.
just keep us updated.

by the way i didn't get your question?

@PriViji
Copy link

PriViji commented Jul 21, 2020 via email

@PriViji
Copy link

PriViji commented Aug 2, 2020

I am trying to use https://www.npmjs.com/package/react-native-chart-kit
But I am getting an error which I couldn't figure out. Can someone help?
Screenshot of the error
Screenshot 2020-08-01 at 8 56 00 PM

@nandini45
Copy link
Member Author

i think it is a plugin issue
.
maybe you have to add a new plugin or something?

@nandini45 nandini45 added the Status: Available Issue was approved and available to claim or abandoned for over 3 days. label Sep 1, 2020
@PriViji
Copy link

PriViji commented Sep 1, 2020 via email

@nandini45
Copy link
Member Author

@parthsarthiprasad are you working on it?

@parthsarthiprasad
Copy link
Contributor

hello, @nandini45 THanks for patiently waiting, got busy with SIH finals, which might wrap up by end of November. I'll weigh in as soon as possible, these issues can be opened for someone else if not found up to the mark.

@nandini45
Copy link
Member Author

@parthsarthiprasad ok.. i will make it available for now.. if you want to claim it later I will assign you if available

@nandini45 nandini45 added the Status: Available Issue was approved and available to claim or abandoned for over 3 days. label Nov 29, 2020
@nandini45 nandini45 mentioned this issue Nov 29, 2020
Open
4 tasks
@Bucky25
Copy link
Contributor

Bucky25 commented Dec 4, 2020

@nandini45 i have started working on it can you assign it

@nandini45 nandini45 removed the Status: Available Issue was approved and available to claim or abandoned for over 3 days. label Dec 4, 2020
@nandini45
Copy link
Member Author

@Bucky25 here

@Bucky25
Copy link
Contributor

Bucky25 commented Dec 4, 2020

@nandini45 i have a suggestion for contribution graph as the can we make it past 30 weeks as github api only provides data weekly or in day format it is for 7 days only and commit in day are also less which makes graph look empty most of block it would be better if we make according to weeks
and one more thing
how does we implement api authentication in this repo i am using token method for it is it good

@Bucky25
Copy link
Contributor

Bucky25 commented Dec 4, 2020

Screenshot from 2020-12-05 00-41-34
any feedback on this this i have implemented according to week

@nandini45
Copy link
Member Author

@Bucky25
I understand ur point but 30 weeks is too much. And moreover i maybe the PM for the project but solely i can't take decision so let's just
Keep it for 30 days only.
Btw what you did is quite a good job.
thanks for the contribution

@Bucky25
Copy link
Contributor

Bucky25 commented Dec 5, 2020

@nandini45 can u give me description of colours of repo name to be written and of the more and less have to be written not given on adobe link given above i have completed implementation of days and will file a pr as soon as colours are with me
and what abt the github api authentication process its important

@nandini45
Copy link
Member Author

@Bucky25 go for the same color as mentioned
and what regarding the authentication process?

@Bucky25
Copy link
Contributor

Bucky25 commented Dec 5, 2020

@nandini45 authentication process requires access token which has to put in put in the .env file and stored in secrets when hosting on git hub

Bucky25 added a commit to Bucky25/anitab-org.github.io that referenced this issue Dec 6, 2020
@Bucky25
develop contribution section in project page anitab-org#80
fafb091
Bucky25 added a commit to Bucky25/anitab-org.github.io that referenced this issue Dec 6, 2020
@Bucky25
develop contribution section in project page anitab-org#80
ea584eb
@Bucky25 Bucky25 linked a pull request Dec 6, 2020 that will close this issue
Open
5 tasks
@Bucky25
Copy link
Contributor

Bucky25 commented Dec 6, 2020 •
edited
Loading

@nandini45 just add a secret named ACCESS_TOKEN in organization repo that is generated from access token so that authorization works
the secret has to be a string format -> 'Token {token to be copied}'

@annabauza
Copy link
Contributor

Ahh access token not sure how to keep it without exposing to everyone...

@prabhat04011998
Copy link
Contributor

i think access toke need to be store in a env file which will be ignored by git, put that file in .gitignore.
i m not sure about it.

@Bucky25
Copy link
Contributor

Bucky25 commented Dec 7, 2020

@prabhat04011998 it is for local use and local testing but for deploying it needs to be strored in secrets on where we are deploying it

@Bucky25
Copy link
Contributor

Bucky25 commented Dec 17, 2020

@annabauza @nandini45 i have suggestion for the contribution box as we should cover in a scroll view as it happens in github page because in responsiveness breaks in smaller screen and row goes in second row . but on github page it just get a scroll in the box which remains in a box .
what are u suggestions abt that

@nandini45
Copy link
Member Author

both approach are fine for me
you can go with just scroll which remains in the box
see its just we need to show the daily progress to the person who comes across it.
Therefore go with the approach that you think will give the result and less time of yours
@Bucky25

@nandini45 nandini45 added the Status: Available Issue was approved and available to claim or abandoned for over 3 days. label May 5, 2021
@Bucky25
Copy link
Contributor

Bucky25 commented May 5, 2021

@nandini45 pull request is under review still .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Bucky25 Bucky25

Labels
Category: Coding Changes to code base or refactored code that doesn't fix a bug. Status: Available Issue was approved and available to claim or abandoned for over 3 days.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Feat: developed contribution section in project page Bucky25/anitab-org.github.io