Bug : the application is not supposed to crash because of a server error

[yveskalume]

Describe the bug

an internal error makes the application crash when a new user tries to signup

To Reproduce

Steps to reproduce the behavior:

1. Go to Sign Up
2. Complete the informations
3. Click on Sign Up button
4. See error the sign up screen will close without message. In the log of android studio you can see "HTTP 500 Internal Server Error".

Expected behavior

an error that something is wrong should be displayed without the application crashing

Smartphone (please complete the following information):

• OS: Android
• Version 10

Additional context

this can be fixed by adding a try catch in the AuthDataManager (I've already tested and it worked)

[epicadk]

Can someone validate this? @anitab-org/mentorship-testers

Also if this is the case why doesn't this work?

mentorship-android/app/src/main/java/org/anitab/mentorship/viewmodels/SignUpViewModel.kt

Lines 29 to 35 in c069751

	try {
	message = authDataManager.register(register).message
	successful.postValue(true)
	} catch (throwable: Throwable) {
	message = CommonUtils.getErrorMessage(throwable, tag)
	successful.postValue(false)
	}

[yveskalume]

@epicadk although there is a try catch in the viewmodel, you have to add another one in the AuthManager and throw an exception in the catch scope

[yveskalume]

Can i open a PR ?

[epicadk]

Sure

[vj-codes]

Can someone validate this? @anitab-org/mentorship-testers

Also if this is the case why doesn't this work?

mentorship-android/app/src/main/java/org/anitab/mentorship/viewmodels/SignUpViewModel.kt

Lines 29 to 35 in c069751

	try {
	message = authDataManager.register(register).message
	successful.postValue(true)
	} catch (throwable: Throwable) {
	message = CommonUtils.getErrorMessage(throwable, tag)
	successful.postValue(false)
	}

Yes the issue is valid, @yveskalume thank you so much for reporting it :)

[rishujam]

Hey, Is this project still being maintained?

[vj-codes]

Hey yes being maintained

[OwaisKhatri]

Do I need to setup the backend also to build & run this Android app?

[vj-codes]

Do I need to setup the backend also to build & run this Android app?

Hey no you can download the apk directly

[OwaisKhatri]

I build this project and run the app from Android Studio.
But, the app gets crashed on sign up.