Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use paging 3 for members list #1166

Open
epicadk opened this issue Oct 3, 2021 · 6 comments · May be fixed by #1221
Open

Use paging 3 for members list #1166

epicadk opened this issue Oct 3, 2021 · 6 comments · May be fixed by #1221
Assignees
@bosankus
Labels
Category: Coding Changes to code base or refactored code that doesn't fix a bug. Open Source Hack

Comments

@epicadk
Copy link
Member

epicadk commented Oct 3, 2021

Is your feature request related to a problem? Please describe.

Currently we are using a custom endless recycler view listener

Describe the solution you'd like

Use the paging 3 library instead.

Describe alternatives you've considered

NA

Additional context

https://developer.android.com/topic/libraries/architecture/paging/v3-migration
@epicadk epicadk added Category: Coding Changes to code base or refactored code that doesn't fix a bug. Status: Available Issue was approved and available to claim or abandoned for over 3 days. labels Oct 11, 2021
@bosankus
Copy link

@epicadk Can I work on this ?

@bosankus
Copy link

@epicadk @isabelcosta Can I start working on this ? Can I get assigned?

@vj-codes
Copy link
Member

@bosankus hey assigning you
Happy coding!

@vj-codes vj-codes removed the Status: Available Issue was approved and available to claim or abandoned for over 3 days. label Nov 18, 2021
@bosankus bosankus mentioned this issue Dec 3, 2021
Open
6 tasks
@bosankus
Copy link

bosankus commented Dec 3, 2021

Implemented feature from issue #1174 will be updated in this issue via future commits.

@vj-codes vj-codes reopened this Jan 27, 2022
@vj-codes vj-codes added the Status: Available Issue was approved and available to claim or abandoned for over 3 days. label Jan 27, 2022
@bosankus
Copy link

@vj-codes apology for making it late. am already working on this issue. and already made few commits on my branch.
Can I continue and deliver as soon as possible?

@bosankus
Copy link

bosankus commented Oct 3, 2022

Hi @vj-codes I have made the changes and want to create a PR for this from my forked repo. Can I get this re-assigned to me ?
You can check my updated code here: https://github.com/bosankus/mentorship-android/tree/paging3-member-list

@epicadk epicadk removed the Status: Available Issue was approved and available to claim or abandoned for over 3 days. label Oct 3, 2022
@bosankus bosankus linked a pull request Oct 4, 2022 that will close this issue
Open
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bosankus bosankus

Labels
Category: Coding Changes to code base or refactored code that doesn't fix a bug. Open Source Hack
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

1166: Migration to Paging3 for MembersFragment bosankus/mentorship-android
3 participants
@bosankus @epicadk @vj-codes