Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove useless mpv files in apk #1587

Open
8 tasks done
SkyD666 opened this issue May 24, 2024 · 4 comments
Open
8 tasks done

Remove useless mpv files in apk #1587

SkyD666 opened this issue May 24, 2024 · 4 comments
Labels
Dependencies Changes in the libraries
Milestone

Comments

@SkyD666
Copy link

SkyD666 commented May 24, 2024

Steps to reproduce

image

For example, the files under the is.xyz.filepicker package should all be useless

Expected behavior

These useless files should not be included.

Actual behavior

A lot of useless mpv files are included in the apk

Crash logs

No response

Aniyomi version

0.15.3.0

Android version

None

Device

None

Other details

No response

Acknowledgements

  • I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open or closed issue.
  • I have written a short but informative title.
  • If this is an issue with an official extension, I should be opening an issue in the extensions repository.
  • If this is an issue with an official manga extension and this issue can be replicated in the Tachiyomi app, that I should be opening an issue in Tachiyomi's extensions repository.
  • I have gone through the FAQ and troubleshooting guide.
  • I have updated the app to version 0.15.3.0.
  • I have updated all installed extensions.
  • I will fill out all of the requested information in this form.
@endersgergo
Copy link

The classes in the is.xyz.* packages are not useless, but legitimate dependencies of Aniyomi. The is.xyz.mpv provides the implementation for video playback using libmpv and my educated guess is that the filepicker package is a dependency pulled in by mpv.

@abdallahmehiz
Copy link
Member

The classes in the is.xyz.* packages are not useless, but legitimate dependencies of Aniyomi. The is.xyz.mpv provides the implementation for video playback using libmpv and my educated guess is that the filepicker package is a dependency pulled in by mpv.

The file picker in the files is the one mpv-android uses, not mpv itself. It's not required to run the player so i see his point in asking for them to be removed.

Sure removing them will give us back 8kb but i think that's quite insignificant compared to the stability that their existence provides when merging from upstream mpv-android in my opinion.

@SkyD666
Copy link
Author

SkyD666 commented Jun 3, 2024

The developer only needs to remove useless files when packaging the mpv-android, and if done properly, this will not reduce the stability of the app.

Details of how to do this can be found here: https://github.com/jarnedemeulemeester/libmpv-android

@SkyD666
Copy link
Author

SkyD666 commented Jun 3, 2024

Also I'm a developer, I use aniyomi's mpv library, but gradle doesn't support removing files from 3rd party libraries, so I can't remove these useless files in my apk, I hope the developer can remove them when upstream packaged with mpv-android, thank you very much!

@abdallahmehiz abdallahmehiz added the Dependencies Changes in the libraries label Jun 5, 2024
@jmir1 jmir1 added this to the fix this milestone Jun 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dependencies Changes in the libraries
Projects
None yet
Development

No branches or pull requests

4 participants