You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
For example, the files under the is.xyz.filepicker package should all be useless
Expected behavior
These useless files should not be included.
Actual behavior
A lot of useless mpv files are included in the apk
Crash logs
No response
Aniyomi version
0.15.3.0
Android version
None
Device
None
Other details
No response
Acknowledgements
I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open or closed issue.
I have written a short but informative title.
If this is an issue with an official extension, I should be opening an issue in the extensions repository.
If this is an issue with an official manga extension and this issue can be replicated in the Tachiyomi app, that I should be opening an issue in Tachiyomi's extensions repository.
The classes in the is.xyz.* packages are not useless, but legitimate dependencies of Aniyomi. The is.xyz.mpv provides the implementation for video playback using libmpv and my educated guess is that the filepicker package is a dependency pulled in by mpv.
The classes in the is.xyz.* packages are not useless, but legitimate dependencies of Aniyomi. The is.xyz.mpv provides the implementation for video playback using libmpv and my educated guess is that the filepicker package is a dependency pulled in by mpv.
The file picker in the files is the one mpv-android uses, not mpv itself. It's not required to run the player so i see his point in asking for them to be removed.
Sure removing them will give us back 8kb but i think that's quite insignificant compared to the stability that their existence provides when merging from upstream mpv-android in my opinion.
Also I'm a developer, I use aniyomi's mpv library, but gradle doesn't support removing files from 3rd party libraries, so I can't remove these useless files in my apk, I hope the developer can remove them when upstream packaged with mpv-android, thank you very much!
Steps to reproduce
For example, the files under the is.xyz.filepicker package should all be useless
Expected behavior
These useless files should not be included.
Actual behavior
A lot of useless mpv files are included in the apk
Crash logs
No response
Aniyomi version
0.15.3.0
Android version
None
Device
None
Other details
No response
Acknowledgements
The text was updated successfully, but these errors were encountered: