Correctly handle unsigned integers in constructor#40
Merged
anj1 merged 1 commit intoanj1:masterfrom Aug 30, 2025
TZdyrski:patch-1
Merged
Correctly handle unsigned integers in constructor#40anj1 merged 1 commit intoanj1:masterfrom TZdyrski:patch-1
anj1 merged 1 commit intoanj1:masterfrom
TZdyrski:patch-1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, the
AlgebraicNumberconstructor gives surprising behavior when using unsigned integers. For example,AlgebraicNumber(UInt8(3)) != AlgebraicNumber(Int(3)).This occurs because the constructor
AlgebraicNumber(x)uses-xwhen calculating the coefficients, which causesUInt8(3) = 0x03to be wrap around to0xfd. Thus, the coefficients ofInt(3)are[-3,1](correct), butUInt(3)gives[253,1].Note: while the internal representations and equality test differ,
AlgebraicNumber(UInt(3)) - AlgebraicNumber(Int(3)) == 0, so testing equality by subtracting is a (slower) workaround.This fix promotes the input of the
AlgebraicNumberconstructor to BigInt to avoid this issue (simply usingsigned(x)would not work assigneddoesn't check for overflow).