Add hash function for type AlgebraicNumber#41
Merged
fkastner merged 1 commit intoanj1:masterfrom Dec 11, 2025
Merged
Conversation
Collaborator
|
Thank you for this addition! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a hash function for
AlgebraicNumber; it is required that any custom type defining its own==(asAlgebraicNumberdoes) also define its own hash so thatisequal(an1, an2)impleshash(an1) == hash(an2).This also fixes Base functions like
unique; previously,unique([AlgebraicNumber(1), AlgebraicNumber(1)])produces two elements when it should only produce one (sinceuniqueinternally useshash). Now, it correctly returns only a single element.I only hashed the coefficients (appropriately scaled); this does satisfy the requirement that
isequal(an1, an2)impleshash(an1) == hash(an2). However, becausehashdoesn't useapprxorprec, differentAlgebraicNumberscan result in the same hash.