Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

control_stream_task does not recover after a network reconnection #9

Open
eshabtai opened this issue Dec 14, 2018 · 1 comment
Open

Comments

@eshabtai
Copy link

_open_connections(self) on connection.py just returns when a network disconnection occurs and the task ends. Upon reconnection the task is not restarted so robot control requests are never granted.

Wrapping the function with a 'while not self._control_events.is_shutdown:' recovers disconnections for me but I have not followed the different code paths so not sure if that's the correct fix.

@kaiseranki
Copy link

Thanks for the note! :) We'll take a look and evaluate options.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants