flags sometime have no colors

[Arthur-Milchior]

No idea why. I can't reproduce systematically. If i close and reopen the menu colors are back.

[david-allison]

Is this reproducible in the new study screen?

Settings -> New Study Screen

[AayushKrGupta]

Is this reproducible in the new study screen?

Settings -> New Study Screen

Hi, I’ve implemented a fix for this issue and opened a PR.

The fix ensures flag drawables are always tinted during UI binding and prevents shared drawable state issues.

PR: #20469

[BrayanDSO]

we need reproduction steps for this

[AayushKrGupta]

we need reproduction steps for this

Hi @BrayanDSO,

This is an intermittent UI bug reproducible in both the Legacy and New Study Screens:

Steps: Open the reviewer, access the flag menu, study several cards, and re-open the menu repeatedly.
Observed Behavior: Flag icons occasionally lose their color and appear grey.

Root Cause: Android's drawable caching reuses the ic_flag instance. If it is retrieved elsewhere without .mutate(), its tinted state is lost or overwritten in the shared ConstantState.

My PR fixes this by ensuring all flag drawables are mutated and explicitly re-tinted during every UI binding.

[david-allison]

@AayushKrGupta Could you send a video? I wouldn't expect a missing mutate() to be the cause if it's the same screen

[ZornHadNoChoice]

I reproduced it in the old study screen but not the new one:

Screenrecorder-2026-03-15-01-54-35-979.mp4

[BrayanDSO]

I remember something similar happening to me in the past on the old study screen. Either way, #20469 changes a lot of screens without the bugs. Keep the fix restricted to what you can reproduce