Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Password should not be stored directly in database #34

Open
HimanshuC22 opened this issue Oct 5, 2023 · 4 comments
Open

Password should not be stored directly in database #34

HimanshuC22 opened this issue Oct 5, 2023 · 4 comments
Assignees
@HimanshuC22
Labels
bug Something isn't working hacktoberfest

Comments

@HimanshuC22
Copy link

Keeping in mind security practices, password should not be stored directly in database, it should be hashed.

@ankitrout2903 please assign me this issue, I want to get ahead with it.
@ankitrout2903 ankitrout2903 added bug Something isn't working hacktoberfest labels Oct 5, 2023
@ankitrout2903
Copy link
Owner

Keeping in mind security practices, password should not be stored directly in database, it should be hashed.

@ankitrout2903 please assign me this issue, I want to get ahead with it.

Great observation go ahead

@HimanshuC22
Copy link
Author

@ankitrout2903 I have created a PR #35 , you can test the backend through postman.

@ankitrout2903
Copy link
Owner

@ankitrout2903 I have created a PR #35 , you can test the backend through postman.

Yes bro let me review code

@HimanshuC22
Copy link
Author

@ankitrout2903 I have added node_modules in gitignore in #35 , have a look. From now on, node modules will not be a part of any commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@HimanshuC22 HimanshuC22

Labels
bug Something isn't working hacktoberfest
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@HimanshuC22 @ankitrout2903