Refactor configuration and improve message handling in the EngineSystem

- Added missing newlines at the end of several configuration files for consistency.
- Updated the logging level in the test configuration from `:warn` to `:warning` for clarity.
- Enhanced message handling in the EngineSystem by restructuring the message dispatching logic, improving readability and maintainability.
- Simplified the diagram generation process by removing redundant error handling and streamlining the code in the DiagramGenerator module.

These changes contribute to a cleaner codebase and better adherence to Elixir conventions.

Author: jonaprieto

config/config.exs

@@ -22,4 +22,4 @@ config :engine_system,
 # Import environment specific config
 if File.exists?("config/#{config_env()}.exs") do
   import_config "#{config_env()}.exs"
-end
+end

config/dev.exs

@@ -7,4 +7,4 @@ config :logger,
 # Development environment settings
 config :engine_system,
   generate_diagrams: false,
-  diagram_output_dir: "docs/diagrams"
+  diagram_output_dir: "docs/diagrams"

config/test.exs

@@ -2,9 +2,9 @@ import Config
 
 # Configure logger for tests
 config :logger,
-  level: :warn
+  level: :warning
 
 # Disable file generation during tests
 config :engine_system,
   compile_engines: false,
-  generate_diagrams: false
+  generate_diagrams: false

lib/engine_system/api.ex

@@ -7,7 +7,7 @@ defmodule EngineSystem.API do
 
   alias EngineSystem.Engine.{Spec, State}
   alias EngineSystem.Lifecycle
-  alias EngineSystem.System.{Registry, Services, Spawner}
+  alias EngineSystem.System.{Message, Registry, Services, Spawner}
 
   @doc """
   I start the EngineSystem application.
@@ -65,7 +65,7 @@ defmodule EngineSystem.API do
     # Use proper address format: {node_id, engine_id} where both are non_neg_integer
     # System address using proper format
     sender_addr = sender_address || {0, 0}
-    message = EngineSystem.System.Message.new(sender_addr, target_address, message_payload)
+    message = Message.new(sender_addr, target_address, message_payload)
 
     # Use the Services.send_message function for actual sending
     Services.send_message(target_address, message)

lib/engine_system/engine.ex

@@ -93,11 +93,36 @@ defmodule EngineSystem.Engine do
   def apply_filter(nil, _message), do: true
 
   def apply_filter(filter, message) do
-    filter.(message)
-  rescue
-    _ -> false
-  catch
-    _ -> false
+    # Check function arity to determine how to call it
+    info = :erlang.fun_info(filter, :arity)
+
+    case info do
+      {:arity, 1} ->
+        try do
+          filter.(message)
+        rescue
+          _ -> false
+        catch
+          _ -> false
+        end
+      {:arity, 3} ->
+        try do
+          filter.(message, nil, nil)
+        rescue
+          _ -> false
+        catch
+          _ -> false
+        end
+      _ ->
+        # Default to 1-arity for backward compatibility
+        try do
+          filter.(message)
+        rescue
+          _ -> false
+        catch
+          _ -> false
+        end
+    end
   end
 
   # Private helper functions