fix(protocol): tighten the goal state machine and /goal parsing

Author: Te-River

packages/client/src/effect/api/api.ts

@@ -1313,6 +1313,7 @@ export type SessionGoalUpdateInput = {
   readonly action: "set" | "clear" | "edit" | "pause" | "resume"
   readonly objective?: string | undefined
   readonly expectedRevision?: number | undefined
+  readonly expectedGoalID?: SessionGoal.ID | undefined
 }
 export type SessionGoalUpdateOutput = SessionGoal.Snapshot
 export type SessionGoalUpdateOperation<E = never> = (
@@ -1322,6 +1323,8 @@ export type SessionGoalUpdateOperation<E = never> = (
 export type SessionTodoReplaceInput = {
   readonly sessionID: Session.ID
   readonly todos: ReadonlyArray<SessionGoal.TodoInput>
+  readonly expectedRevision?: number | undefined
+  readonly expectedGoalID?: SessionGoal.ID | undefined
 }
 export type SessionTodoReplaceOutput = void
 export type SessionTodoReplaceOperation<E = never> = (

packages/client/src/effect/generated/client.ts

@@ -739,7 +739,12 @@ const EndpointSessionGoalUpdate = (raw: RawClient["server.session"]) => (input:
   preserveEffect<SessionGoalUpdateOutput>()(
     raw["session.goal.update"]({
       params: { sessionID: input["sessionID"] },
-      payload: { action: input["action"], objective: input["objective"], expectedRevision: input["expectedRevision"] },
+      payload: {
+        action: input["action"],
+        objective: input["objective"],
+        expectedRevision: input["expectedRevision"],
+        expectedGoalID: input["expectedGoalID"],
+      },
     }).pipe(
       Effect.mapError(mapClientError),
       Effect.map((value) => value.data),
@@ -748,9 +753,14 @@ const EndpointSessionGoalUpdate = (raw: RawClient["server.session"]) => (input:
 
 const EndpointSessionTodoReplace = (raw: RawClient["server.session"]) => (input: SessionTodoReplaceInput) =>
   preserveEffect<SessionTodoReplaceOutput>()(
-    raw["session.todo.replace"]({ params: { sessionID: input["sessionID"] }, payload: { todos: input["todos"] } }).pipe(
-      Effect.mapError(mapClientError),
-    ),
+    raw["session.todo.replace"]({
+      params: { sessionID: input["sessionID"] },
+      payload: {
+        todos: input["todos"],
+        expectedRevision: input["expectedRevision"],
+        expectedGoalID: input["expectedGoalID"],
+      },
+    }).pipe(Effect.mapError(mapClientError)),
   )
 
 const EndpointSessionMessageGet = (raw: RawClient["server.session"]) => (input: SessionMessageGetInput) =>

packages/client/src/promise/generated/client.ts

@@ -1041,6 +1041,7 @@ export function make(options: ClientOptions) {
                 action: input["action"],
                 objective: input["objective"],
                 expectedRevision: input["expectedRevision"],
+                expectedGoalID: input["expectedGoalID"],
               },
               successStatus: 200,
               declaredStatuses: [400, 401, 404, 409],
@@ -1055,7 +1056,11 @@ export function make(options: ClientOptions) {
             {
               method: "PUT",
               path: `/api/session/${encodeURIComponent(input.sessionID)}/todo`,
-              body: { todos: input["todos"] },
+              body: {
+                todos: input["todos"],
+                expectedRevision: input["expectedRevision"],
+                expectedGoalID: input["expectedGoalID"],
+              },
               successStatus: 204,
               declaredStatuses: [400, 401, 404, 409],
               empty: true,