test(core): restore the goal revision guards in the driver branch

Author: Te-River

packages/core/test/session-goal.test.ts

@@ -143,20 +143,58 @@ describe("SessionGoal", () => {
     }),
   )
 
-  it.effect("todo.updated replaces the whole list and replay is a no-op", () =>
+  it.effect("todo.updated replaces the whole list and a replayed event is a no-op", () =>
     Effect.gen(function* () {
       const { db, bus } = yield* setup
-      yield* bus.publish(SessionEvent.Todo.Updated, { sessionID, revision: 1, todos })
+      yield* bus.publish(SessionEvent.Goal.Updated, { sessionID, snapshot: snapshot(1) })
+      yield* bus.publish(SessionEvent.Todo.Updated, { sessionID, revision: 2, todos })
       expect(yield* SessionGoal.readTodo(db, sessionID)).toEqual([
         { position: 0, content: "first", status: "pending", acceptance: "tests pass", feedback: undefined },
         { position: 1, content: "second", status: "in_progress", acceptance: undefined, feedback: undefined },
       ])
 
-      yield* bus.publish(SessionEvent.Todo.Updated, { sessionID, revision: 1, todos })
+      // The same revision arrives twice; only the first one advances the goal.
+      yield* bus.publish(SessionEvent.Todo.Updated, { sessionID, revision: 2, todos: [todos[0]] })
       expect(yield* SessionGoal.readTodo(db, sessionID)).toHaveLength(2)
     }),
   )
 
+  it.effect("todo.updated never rewinds the goal revision, so a stale verdict stays rejected", () =>
+    Effect.gen(function* () {
+      const { db, bus } = yield* setup
+      yield* bus.publish(SessionEvent.Goal.Updated, { sessionID, snapshot: snapshot(1) })
+      yield* bus.publish(SessionEvent.Todo.Updated, { sessionID, revision: 2, todos })
+      yield* bus.publish(SessionEvent.Todo.Updated, { sessionID, revision: 3, todos })
+
+      // A late list event carrying an older revision must not move the goal back to a
+      // number a verdict judged against the previous list still carries.
+      yield* bus.publish(SessionEvent.Todo.Updated, { sessionID, revision: 2, todos: [todos[0]] })
+      expect(yield* SessionGoal.read(db, sessionID)).toMatchObject({ revision: 3 })
+      expect(yield* SessionGoal.readTodo(db, sessionID)).toHaveLength(2)
+
+      yield* bus.publish(SessionEvent.Todo.Verified, {
+        sessionID,
+        revision: 2,
+        items: [{ position: 0, status: "completed", feedback: "stale" }],
+      })
+      expect((yield* rounds(db))?.rounds).toBe(0)
+      expect(yield* SessionGoal.readTodo(db, sessionID)).toEqual([
+        { position: 0, content: "first", status: "pending", acceptance: "tests pass", feedback: undefined },
+        { position: 1, content: "second", status: "in_progress", acceptance: undefined, feedback: undefined },
+      ])
+    }),
+  )
+
+  it.effect("todo.updated without a goal row is dropped", () =>
+    Effect.gen(function* () {
+      const { db, bus } = yield* setup
+      // A list only exists under a goal, so an event without one leaves no state.
+      yield* bus.publish(SessionEvent.Todo.Updated, { sessionID, revision: 1, todos })
+      expect(yield* SessionGoal.read(db, sessionID)).toBeUndefined()
+      expect(yield* SessionGoal.readTodo(db, sessionID)).toEqual([])
+    }),
+  )
+
   it.effect("todo.verified applies a fresh verdict", () =>
     Effect.gen(function* () {
       const { db, bus } = yield* setup
@@ -210,10 +248,7 @@ describe("SessionGoal", () => {
         items: [{ position: 0, status: "completed", feedback: "ok" }],
       })
       expect(yield* SessionGoal.read(db, sessionID)).toBeUndefined()
-      expect(yield* SessionGoal.readTodo(db, sessionID)).toEqual([
-        { position: 0, content: "first", status: "pending", acceptance: "tests pass", feedback: undefined },
-        { position: 1, content: "second", status: "in_progress", acceptance: undefined, feedback: undefined },
-      ])
+      expect(yield* SessionGoal.readTodo(db, sessionID)).toEqual([])
     }),
   )
 })