fix(tui): move props.ref to onMount #7702
Merged
+32
−33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
The following comment was made by an LLM, it may be inaccurate: No duplicate PRs found |
Contributor
Author
|
@rekram1-node This is the PR for the code I was talking about earlier |
Collaborator
|
/review |
Contributor
|
lgtm |
This was referenced Jan 11, 2026
zerone0x
pushed a commit
to zerone0x/opencode
that referenced
this pull request
Jan 12, 2026
zerone0x
pushed a commit
to zerone0x/opencode
that referenced
this pull request
Jan 12, 2026
liorshk
pushed a commit
to liorshk/opencode
that referenced
this pull request
Jan 17, 2026
triklozoid
pushed a commit
to triklozoid/opencode
that referenced
this pull request
Feb 2, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #7633 & possibly #7634
What does this PR do?
Currently there is an issue where forking from the first message of a session causes a fatal crash since
the session route calls
r.set(route.initialPrompt)immediately after receiving the ref, but theinputis not valid until thetextareacomponent is ready later on-down in the component hierarchy.This PR moves the
Prompt props.reflogic into theonMountlifecycle component to ensure that the ref is only invoked when the component is fully ready.How did you verify your code works?
fork-message-fix.mov