fix: race condition causing prompt.set undefined error#7872
Closed
chriswritescode-dev wants to merge 1 commit intoanomalyco:devfrom
Closed
fix: race condition causing prompt.set undefined error#7872chriswritescode-dev wants to merge 1 commit intoanomalyco:devfrom
chriswritescode-dev wants to merge 1 commit intoanomalyco:devfrom
Conversation
Contributor
|
The following comment was made by an LLM, it may be inaccurate: Perfect! I found a highly relevant duplicate: Potential Duplicate FoundPR #7764 - fix: prevent prompt crash when opening new session with existing prompt This PR appears to address the same issue: preventing a crash related to the prompt when opening/starting a new session from within an existing session. It's almost certainly covering the same race condition bug that PR #7872 is fixing. |
Fixes a race condition where onMount() was called before the prompt ref was initialized, causing "undefined is not an object (evaluating 'prompt.set')" error when starting a new session from inside an existing session. Changed from onMount() to createEffect() with a prompt existence check, matching the pattern used in session/index.tsx. Fixes anomalyco#7870
chriswritescode-dev
force-pushed
the
fix/7870-prompt-race-condition
branch
from
0f10baa to
ccde828
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a race condition where
onMount()was called before thepromptref was initialized, causing a "undefined is not an object (evaluating 'prompt.set')" error when starting a new session from inside an existing session.Root Cause
In
packages/opencode/src/cli/cmd/tui/routes/home.tsx:79-90, theonMount()hook attempted to callprompt.set()before the ref had been assigned by the<Prompt ref={(r) => { prompt = r }} />component. This resulted inpromptbeing undefined during execution.Fix
onMount()tocreateEffect()which re-evaluates when reactive dependencies changeif (once || !prompt) returnto check if the prompt ref existsFixes #7870