Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make string comparisons work with Julia v1.0 #3

Closed
anowacki opened this issue Aug 4, 2021 · 0 comments
Closed

Make string comparisons work with Julia v1.0 #3

anowacki opened this issue Aug 4, 2021 · 0 comments

Comments

@anowacki
Copy link
Owner

anowacki commented Aug 4, 2021

Make string comparisons work on Julia v1.0. Currently we can't use === to compare due to a bug whose fix is only due to be backported in Julia v1.0.6; however there may not be any v1.0.6 at all.

  • Possible solution: set a comparison via e.g.

    @static if VERSION < v1.2
    const STRING_COMPARISON_OP = :(==)
else
    const STRING_COMPARISON_OP = :(===)
end

    and then @eval this into the individual parse_node methods in
    src/base_types and src/derived_types.jl, and the @generated method in src/io.jl
@anowacki anowacki mentioned this issue Aug 4, 2021
Closed
anowacki added a commit that referenced this issue Aug 4, 2021
@anowacki
Drop support for Julia < v1.2
f5643c0 
Stop supporting Julia v1.0 due to a bug in string comparisons with
`===`. (See
#3)

It may be possible to support it again in the future if needed.
@anowacki anowacki closed this as completed Aug 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@anowacki