onepassword_info: replace subprocess.Popen() with run_command() (#11193)

* onepassword_info: replace subprocess.Popen() with run_command()

* add changelog frag

* Update plugins/modules/onepassword_info.py

Co-authored-by: Felix Fontein <[email protected]>

---------

Co-authored-by: Felix Fontein <[email protected]>
(cherry picked from commit f2731e1)

Author: 2 people

changelogs/fragments/11193-onepassword-info-popen.yml

@@ -0,0 +1,2 @@
+minor_changes:
+  - onepassword_info - execute external commands using Ansible construct (https://github.com/ansible-collections/community.general/pull/11193).

plugins/modules/onepassword_info.py

@@ -159,8 +159,6 @@
 import os
 import re
 
-from subprocess import Popen, PIPE
-
 from ansible.module_utils.common.text.converters import to_bytes, to_native
 from ansible.module_utils.basic import AnsibleModule
 
@@ -193,9 +191,7 @@ def _run(self, args, expected_rc=0, command_input=None, ignore_errors=False):
             args += [to_bytes("--session=") + self.token]
 
         command = [self.cli_path] + args
-        p = Popen(command, stdout=PIPE, stderr=PIPE, stdin=PIPE)
-        out, err = p.communicate(input=command_input)
-        rc = p.wait()
+        rc, out, err = module.run_command(command, data=command_input, check_rc=False, binary_data=True, encoding=None)
         if not ignore_errors and rc != expected_rc:
             raise AnsibleModuleError(to_native(err))
         return rc, out, err