chore: enable mypy with baseline

Related: orsinium-labs/mypy-baseline#30

Author: ssbarnea

.pre-commit-config.yaml

@@ -1,12 +1,34 @@
 ---
+# cspell: ignore gitmoji
 ci:
   # We rely on renovate to update it but there is no way to fully disable it
   # https://github.com/pre-commit-ci/issues/issues/83
   autoupdate_schedule: quarterly
   skip:
     - ansible-lint
+    - uv-lock
     - renovate-config-validator # container limits
 repos:
+  - repo: https://github.com/commitizen-tools/commitizen
+    rev: v4.8.3
+    hooks:
+      - id: commitizen
+        additional_dependencies:
+          - cz-conventional-gitmoji
+      - id: commitizen-branch
+        stages:
+          - pre-push
+  - repo: https://github.com/astral-sh/uv-pre-commit
+    rev: 0.8.13
+    hooks:
+      - id: uv-sync
+      - id: uv-lock
+        name: "deps: upgrade via uv sync --upgrade"
+        alias: deps
+        args: ["--upgrade"]
+        stages: [manual]
+      - id: uv-lock
+        alias: lock
   - repo: https://github.com/renovatebot/pre-commit-hooks
     rev: 41.91.1
     hooks:
@@ -69,6 +91,16 @@ repos:
       - id: ruff-check
         args: ["--fix"]
         alias: ruff
+  # Uncomment once https://github.com/orsinium-labs/mypy-baseline/pull/30 is released
+  # - repo: https://github.com/pre-commit/mirrors-mypy
+  #   rev: v1.17.1
+  #   hooks:
+  #     - id: mypy
+  #       pass_filenames: false
+  #       additional_dependencies:
+  #         - mypy-baseline
+  #         - types-toml
+  # keep at bottom as these are slower
   - repo: https://github.com/ansible/ansible-lint
     rev: v25.8.2
     hooks:

mypy-baseline.txt

@@ -11,6 +11,8 @@ build-backend = "setuptools.build_meta"
 dev = [
   "bindep>=2.13.0",
   "molecule[test]>=25.1.0",
+  "mypy>=1.17.1",
+  "mypy-baseline>=0.7.3",
   "pytest-helpers-namespace>=2019.1.8"
 ]
 docker = [
@@ -23,7 +25,8 @@ lint = [
   "molecule>=25.7.0",
   "pre-commit>=4.1",
   "pre-commit-uv>=4.1.4",
-  "toml>=0.10.2"
+  "toml>=0.10.2",
+  "types-toml>=0.10.8.20240310"
 ]
 pkg = [
   "build>=0.9",
@@ -122,16 +125,36 @@ changelog = "https://github.com/ansible-community/molecule-plugins/releases"
 [tool.codespell]
 skip = "uv.lock"
 
+[tool.mypy]
+files = "."
+color_output = true
+error_summary = true
+# explicit_package_bases = true
+namespace_packages = false
+exclude = [
+  ".ansible",
+  ".cache",
+  ".tox",
+  ".venv",
+  "node_modules",
+  "build",
+  "dist",
+  "site",
+  "scenarios"
+]
+strict = true
+
 [tool.pytest.ini_options]
 addopts = "-v -rxXs --doctest-modules --durations 10 -p no:pytest_ansible"
 doctest_optionflags = "ALLOW_UNICODE ELLIPSIS"
 junit_suite_name = "molecule_test_suite"
 norecursedirs = ["dist", "doc", "build", ".tox", ".eggs", "src", "test/*/scenarios", "test/*/resources"]
 
 [tool.ruff]
-target-version = "py39"
+target-version = "py310"
 # Same as Black.
 line-length = 88
+unsafe-fixes = true
 lint.ignore = [
   "E501", # we use black
   # we deliberately ignore these:
@@ -201,6 +224,8 @@ runner = "uv-venv-lock-runner"
 skip_install = false
 commands_pre = []
 commands = [
+  # move inside a pre-commit hook once https://github.com/orsinium-labs/mypy-baseline/pull/30 is released
+  ["bash", "-c", "mypy | mypy-baseline filter --hide-stats --allow-unsynced && mypy | mypy-baseline sync --sort-baseline"],
   ["pre-commit", "run", "-a"],
   ["bash", "{tox_root}/tools/generate-templates.sh"],
   ["rm", "-rf", "test/roles"]

pyproject.toml

@@ -6,9 +6,9 @@
 import subprocess
 from pathlib import Path
 
+import openstack
 import pytest
 
-import openstack
 from conftest import change_dir_to
 from molecule import logger
 from molecule.app import get_app

test/vagrant-plugin/__init__.py renamed to test/__init__.py

@@ -38,8 +38,7 @@ def is_vagrant_supported() -> bool:
     """Return True if vagrant is installed and current platform is supported."""
     if not shutil.which("vagrant"):
         return False
-    if not (platform.machine() == "arm64" and platform.system() == "Darwin"):
-        return True
+    return bool(not (platform.machine() == "arm64" and platform.system() == "Darwin"))
 
 
 @pytest.mark.skipif(