-
Notifications
You must be signed in to change notification settings - Fork 677
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Incorrect lint error for cisco.ios.ios_command and cisco.ios.ios_config modules in Ansible-Lint 24.5.0 #4178
Comments
I can confirm this, different module, same behaviour: fqcn[canonical]: You should use canonical module name `dellemc.enterprise_sonic.sonic` instead of `dellemc.enterprise_sonic.sonic_interfaces`.
roles/sonic_ports/tasks/main.yml:68 Task/Handler: Configure interfaces
fqcn[canonical]: You should use canonical module name `dellemc.enterprise_sonic.sonic` instead of `dellemc.enterprise_sonic.sonic_l2_interfaces`.
roles/sonic_ports/tasks/main.yml:72 Task/Handler: Configure Interfaces Layer 2
fqcn[canonical]: You should use canonical module name `dellemc.enterprise_sonic.sonic` instead of `dellemc.enterprise_sonic.sonic_l3_interfaces`.
roles/sonic_ports/tasks/main.yml:76 Task/Handler: Configure intrefaces layer 3
|
It appears that this behavior is not limited to the Cisco FQCN, as you have confirmed with the "dellemc.enterprise_sonic.sonic" module. The workaround my colleague suggested is to add this to the ansible-lint ignore list. But this not a solution. I hope someone has an Idea or there is a fix for it. |
Had same issue (with cisco.nxos). I downgraded to 24.2.0 and it works fine again. Awaiting some kind of fix. |
Same with the dellemc.os10 collection
|
Not sure if it's the same issue, but I'm seeing similar in 24.5.0 but bizarely it's suggesting I use |
Got the same on Had to change container image from
|
Any update on this? I was trying to not put a # noqa on these lines since it does seem like a bug that should be fixed, but a month later and it is still present and causing false errors in our pipeline |
@MallocArray, temporarily you can put them in your Ansible-lint ignore list. |
I just tested 24.7.0 and this is still broken for anyone using cisco.xxx modules. |
Indeed, same issue with |
Summary
The latest version of Ansible-Lint (24.5.0) incorrectly identifies the cisco.ios.ios_command and cisco.ios.ios_config modules as lint errors, although the FQCN names are correct according to the Cisco Ansible documentation.
Issue Type
OS / ENVIRONMENT
STEPS TO REPRODUCE
Create a playbook with tasks using cisco.ios.ios_command and cisco.ios.ios_config modules.
Run ansible-lint 24.5.0 on the playbook.
Expected Behavior:
Ansible-Lint should recognize cisco.ios.ios_command and cisco.ios.ios_config as valid FQCNs and not flag them as errors.
Actual Behavior:
Ansible-Lint incorrectly flags these modules as errors, suggesting the use of cisco.ios.ios instead, which is not a valid module name according to the Cisco Ansible documentation.
Environment:
Ansible-Lint version: 24.2.3
Ansible version: 2.16.6
Operating System: debian 12
Additional Context:
The documentation from Cisco Ansible clearly states the use of cisco.ios.ios_command and cisco.ios.ios_config as correct module names. This lint error seems to be a false positive.
References:
Cisco Ansible Documentation: [link to the relevant documentation]
Please let me know if you need any further information.
Thank you for your attention to this issue.
Desired Behavior
ansbible-lint should not recognize the cisco.ios.ios_command and other module names as conflict or lint violations
Possible security bugs should be reported via email to
[email protected]
Actual Behavior
Ansible-Lint incorrectly flags these modules as errors, suggesting the use of cisco.ios.ios instead, which is not a valid module name according to the Cisco Ansible documentation.
Please give some details of what is happening. Include a minimum complete
verifiable example with:
ansible-playbook --syntax-check playbook
The text was updated successfully, but these errors were encountered: