Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARI --scan-per-target resulting into ARI suggestion for multiple targets under one parent target #249

Open
justjais opened this issue Jun 24, 2024 · 1 comment

Comments

@justjais
Copy link
Contributor

justjais commented Jun 24, 2024

ARI --scan-per-target resulting into ARI suggestion for multiple targets under one parent target

This issue results in discrepancy where parsing logic for --fix results in failure and starts resulting into unexpected result.

Screenshot 2024-06-24 at 11 50 46 AM

Steps to reproduce:

  1. Clone parent repo, where the issue is observed: https://github.com/craig-br/workshops
  2. Run the ARI scan as:
ari project ansible-workshops --out-dir /tmp/AW --save-only-rule-result --scan-per-target --task-num-threshold 100
  1. Parse the output result for the taskfile under path: https://github.com/craig-br/workshops/tree/devel/roles/manage_ec2_instances/tasks/ami_find
@justjais
Copy link
Contributor Author

As discussed with @hirokuni-kitahara for fixing the inline replace functionality, I'll include a fix under --fix implementation logic, to parse and mutate only for parent target file and skip ARI suggestions for files other than the parent target name.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant